Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Replace int with std::underlying_type in DECLARE_ENUM_AS_BIT_SET and DECLARE_POSTFIX_INCREMENT. #7533

Merged

Conversation

@PeterN
Copy link
Member

PeterN commented Apr 21, 2019

This fixes 64 bit uses of this macro.

This fixes 64 bit uses of this macro.
@LordAro

This comment has been minimized.

Copy link
Member

LordAro commented Apr 21, 2019

Would be nice if the postfix increment could be fixed as well, for consistency

@PeterN PeterN changed the title Fix: Replace int with std::underlying_type in DECLARE_ENUM_AS_BIT_SET. Fix: Replace int with std::underlying_type in DECLARE_ENUM_AS_BIT_SET and DECLARE_POSTFIX_INCREMENT. Apr 21, 2019
@glx22
glx22 approved these changes Apr 21, 2019
@PeterN PeterN merged commit 66cd32a into OpenTTD:master Apr 21, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190421.4 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.