Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TinyEnumT type #7538

Merged
merged 24 commits into from Apr 29, 2019
Merged

Remove TinyEnumT type #7538

merged 24 commits into from Apr 29, 2019

Conversation

@LordAro
Copy link
Member

LordAro commented Apr 22, 2019

No description provided.

@LordAro LordAro force-pushed the LordAro:tinyenumt-remove branch 3 times, most recently from 7b97ffd to c12d322 Apr 22, 2019
STAT_CLASS_BEGIN = 0, ///< the lowest valid value
STAT_CLASS_DFLT = 0, ///< Default station class.
STAT_CLASS_WAYP, ///< Waypoint class.
STAT_CLASS_MAX = 256, ///< Maximum number of classes.
STAT_CLASS_MAX = 255, ///< Maximum number of classes.

This comment has been minimized.

Copy link
@glx22

glx22 Apr 22, 2019

Contributor

This change may need more work because the max value is used as array declaration size in

static NewGRFClass<Tspec, Tid, Tmax> classes[Tmax];
and
NewGRFClass<Tspec, Tid, Tmax> NewGRFClass<Tspec, Tid, Tmax>::classes[Tmax];

Edit: after looking at the newgrf station spec it may be correct.

src/zoom_type.h Outdated Show resolved Hide resolved
src/build_vehicle_gui.cpp Outdated Show resolved Hide resolved
src/console_cmds.cpp Outdated Show resolved Hide resolved
src/pathfinder/yapf/yapf_road.cpp Outdated Show resolved Hide resolved
src/pathfinder/yapf/yapf_ship.cpp Outdated Show resolved Hide resolved
@LordAro LordAro force-pushed the LordAro:tinyenumt-remove branch from 4987307 to 130d16f Apr 25, 2019
@PeterN
PeterN approved these changes Apr 27, 2019
@PeterN PeterN merged commit 9e19a5f into OpenTTD:master Apr 29, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190425.8 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.