Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix some GUI scaling #7539
Merged
Fix some GUI scaling #7539
Conversation
This comment has been minimized.
This comment has been minimized.
|
I'm not proud of how I did the title game zoom by UI scale, it's very much a hack. It also does not update the zoom when changing UI scale in Options. |
This comment has been minimized.
This comment has been minimized.
|
Never mind the above comment, I found a better way to handle title game zoom. |
This comment has been minimized.
This comment has been minimized.
|
Normal UI scale (with these patches applied, but looks the same without): 2x UI scale, without these fixes (taken with 1.9.1 and different config, hence different fonts): 2x UI scale, with fixes: |
This comment has been minimized.
This comment has been minimized.
|
If a 1.9.2 happens I think this should be backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nielsmh commentedApr 23, 2019
•
edited
Various GUI elements were not being scaled appropriately with UI scale set to 2x and 4x. Especially newspapers and query boxes were too narrow.
This also scales up the news ticker scroll speed by UI scale, as it otherwise goes by too slow to clear the screen.
Zooming the title game by GUI scale should also avoid most problems like the following, 1.9 title game in 3840 pixel wide showing far more than planned for:
