Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Crash on waypoint selection window #7552

Merged
merged 1 commit into from Apr 30, 2019

Conversation

@kiwitreekor
Copy link
Contributor

kiwitreekor commented Apr 30, 2019

The game crashes when joining waypoints, since waypoints have no coverage.

@kiwitreekor kiwitreekor force-pushed the kiwitreekor:fix-waypoint-crash branch from 9323282 to 364fbe9 Apr 30, 2019
@LordAro

This comment has been minimized.

Copy link
Member

LordAro commented Apr 30, 2019

type_traits! Interesting.

Would probably be better to use the existing method of distinguishing between waypoints and stations though - T::EXPECTED_FACIL == FACIL_WAYPOINT ?

@kiwitreekor kiwitreekor force-pushed the kiwitreekor:fix-waypoint-crash branch from 364fbe9 to 819d206 Apr 30, 2019
@kiwitreekor

This comment has been minimized.

Copy link
Contributor Author

kiwitreekor commented Apr 30, 2019

I didn't know that way...
Now I fixed to use that way.

@PeterN
PeterN approved these changes Apr 30, 2019
@PeterN PeterN merged commit 28b23a6 into OpenTTD:master Apr 30, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190430.3 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@kiwitreekor kiwitreekor deleted the kiwitreekor:fix-waypoint-crash branch Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.