Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add industry production graph #7575

Open
wants to merge 1 commit into
base: master
from

Conversation

@kiwitreekor
Copy link
Contributor

kiwitreekor commented May 7, 2019

  • This patch adds a window showing industry production history in last 24 months. (which already exists in Chris Sawyer's Locomotion)
    production_history
src/graph_gui.cpp Outdated Show resolved Hide resolved
src/industry_cmd.cpp Outdated Show resolved Hide resolved
src/widgets/graph_widget.h Show resolved Hide resolved
@nielsmh

This comment has been minimized.

Copy link
Contributor

nielsmh commented May 7, 2019

Commit checker found some whitespace problems:

*** b/src/graph_gui.cpp:1667: Trailing whitespace: '					'
*** b/src/graph_gui.cpp:1750: Trailing whitespace: '			'
*** b/src/graph_gui.cpp:1752: Trailing whitespace: '			'
@kiwitreekor kiwitreekor force-pushed the kiwitreekor:industry-production-graph branch 2 times, most recently from 889a104 to af3332c May 8, 2019
@kiwitreekor

This comment has been minimized.

Copy link
Contributor Author

kiwitreekor commented May 8, 2019

Commit checker found some whitespace problems:

*** b/src/graph_gui.cpp:1667: Trailing whitespace: '					'
*** b/src/graph_gui.cpp:1750: Trailing whitespace: '			'
*** b/src/graph_gui.cpp:1752: Trailing whitespace: '			'

Should be fixed in 889a104.

@kiwitreekor kiwitreekor force-pushed the kiwitreekor:industry-production-graph branch from af3332c to 966b7cd May 8, 2019
src/industry_gui.cpp Outdated Show resolved Hide resolved
src/saveload/saveload.h Outdated Show resolved Hide resolved
@kiwitreekor kiwitreekor force-pushed the kiwitreekor:industry-production-graph branch from 966b7cd to ee7478d May 9, 2019
src/saveload/saveload.h Outdated Show resolved Hide resolved
@kiwitreekor kiwitreekor force-pushed the kiwitreekor:industry-production-graph branch from ee7478d to a1f6475 May 9, 2019
@LordAro LordAro dismissed PeterN’s stale review May 9, 2019

resolved

@nielsmh

This comment has been minimized.

Copy link
Contributor

nielsmh commented May 11, 2019

This needs to be updated as the savegame version as been bumped.

@PeterN

This comment has been minimized.

Copy link
Member

PeterN commented May 11, 2019

Currently display units for weight and volume are ignored, which is not ideal. This will also affect how the graph scales, and I'm not sure how it should handle oil rigs which have passengers tens and oil in the tens of thousands of litres.

@PeterN

This comment has been minimized.

Copy link
Member

PeterN commented May 11, 2019

Another issue, graphs are not being redrawn properly on new a month, leading to visual glitches.

@kiwitreekor kiwitreekor force-pushed the kiwitreekor:industry-production-graph branch from a1f6475 to d7eea7d May 11, 2019
@kiwitreekor

This comment has been minimized.

Copy link
Contributor Author

kiwitreekor commented May 11, 2019

This needs to be updated as the savegame version as been bumped.

Now rebased to e7f6f07.

@kiwitreekor kiwitreekor force-pushed the kiwitreekor:industry-production-graph branch from d7eea7d to 754eb30 May 11, 2019
@kiwitreekor

This comment has been minimized.

Copy link
Contributor Author

kiwitreekor commented May 11, 2019

Another issue, graphs are not being redrawn properly on new a month, leading to visual glitches.

Now graphs are set dirty in UpdateStatisitics. This may resolve the issue.

@kiwitreekor kiwitreekor force-pushed the kiwitreekor:industry-production-graph branch from 754eb30 to 400135d May 11, 2019
@kiwitreekor

This comment has been minimized.

Copy link
Contributor Author

kiwitreekor commented May 12, 2019

Currently display units for weight and volume are ignored, which is not ideal. This will also affect how the graph scales, and I'm not sure how it should handle oil rigs which have passengers tens and oil in the tens of thousands of litres.

hmm... maybe should I limit the number of showing cargoes to one at once?

@PeterN

This comment has been minimized.

Copy link
Member

PeterN commented May 12, 2019

I don't think that's useful. The player can do that themselves with the filter anyway.

@kiwitreekor

This comment has been minimized.

Copy link
Contributor Author

kiwitreekor commented May 30, 2019

bump?

src/graph_gui.cpp Outdated Show resolved Hide resolved
src/graph_gui.cpp Outdated Show resolved Hide resolved
@kiwitreekor kiwitreekor force-pushed the kiwitreekor:industry-production-graph branch from 400135d to bb5d93f Jun 16, 2019
@kiwitreekor

This comment has been minimized.

Copy link
Contributor Author

kiwitreekor commented Jun 16, 2019

Sorry for late reply...

@kiwitreekor kiwitreekor force-pushed the kiwitreekor:industry-production-graph branch from bb5d93f to 69a95a5 Jun 16, 2019
@kiwitreekor

This comment has been minimized.

Copy link
Contributor Author

kiwitreekor commented Jul 23, 2019

bump

@kiwitreekor kiwitreekor force-pushed the kiwitreekor:industry-production-graph branch 2 times, most recently from 30299e5 to d470426 Sep 9, 2019
@kiwitreekor kiwitreekor force-pushed the kiwitreekor:industry-production-graph branch from d470426 to f6c21f6 Sep 9, 2019
@kiwitreekor kiwitreekor force-pushed the kiwitreekor:industry-production-graph branch from f6c21f6 to a742aeb Oct 6, 2019
@kiwitreekor

This comment has been minimized.

Copy link
Contributor Author

kiwitreekor commented Oct 12, 2019

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.