Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7224: Drag and drop vehicle group creation does not work correctly. #7581

Merged
merged 1 commit into from May 10, 2019

Conversation

@stormcone
Copy link
Contributor

@stormcone stormcone commented May 10, 2019

When drag and drop a vehicle into an empty slot in the vehicle group window it tries to create the new group as the subgroup of the first group (GroupID = 0). This is failing if the dragged vehicle's type is different than the first group's vehicle type.

…correctly.

When drag and drop a vehicle into an empty slot in the vehicle group window it tries to create the new group as the subgroup of the first group (GroupID = 0). This is failing if the dragged vehicle's type is different than the first group's vehicle type.
Copy link
Contributor

@nielsmh nielsmh left a comment

I did notice this bug myself, and the fix here looks right.

@PeterN
Copy link
Member

@PeterN PeterN commented May 10, 2019

Oh dear, I never knew that was a thing, hence didn't test it!

@nielsmh nielsmh merged commit 24c5928 into OpenTTD:master May 10, 2019
8 checks passed
@stormcone stormcone deleted the patch-1 branch May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants