Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add:Three currencies: NTD, CNY, HKD #7596

Merged
merged 1 commit into from Jun 9, 2019
Merged

Conversation

@iigmir
Copy link
Contributor

iigmir commented May 16, 2019

As titled, NTD, CNY, HKD are popular currencies in Chinese-speaking area. But there're no currencies there, so I added these currencies.

Another question: Can I translate something by editing src/lang/xx.txt?

@glx22

This comment has been minimized.

Copy link
Contributor

glx22 commented May 17, 2019

Translations are made via http://translator.openttd.org/

src/currency.h Outdated Show resolved Hide resolved
Copy link
Contributor

nielsmh left a comment

Translations should always be made via the web translator. Please remove the changes to simplified_chinese.txt and traditional_chinese.txt from this PR.

@nielsmh

This comment has been minimized.

Copy link
Contributor

nielsmh commented May 24, 2019

The commit checker is failing because two of the commits have bad commit messages. I'd recommend just squashing the two later commits into the first, and keeping the first commit message. After squashing locally, just force-push to your branch on Github, this gets handled correctly by the PR.

@iigmir iigmir force-pushed the iigmir:add-ntd-cny-hkd branch from 47d20d4 to ab07237 May 24, 2019
@LordAro
LordAro approved these changes Jun 6, 2019
@nielsmh nielsmh merged commit 5b09323 into OpenTTD:master Jun 9, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190524.2 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@hpiirai

This comment has been minimized.

Copy link

hpiirai commented Jun 9, 2019

I believe the currency code of the New Taiwan dollar should be TWD rather than NTD.
See Wikipedia: New Taiwan dollar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.