Add:Three currencies: NTD, CNY, HKD #7596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Translations are made via http://translator.openttd.org/ |
nikolas
reviewed
May 17, 2019
nielsmh
requested changes
May 22, 2019
Translations should always be made via the web translator. Please remove the changes to simplified_chinese.txt and traditional_chinese.txt from this PR.
nielsmh
previously approved these changes
May 24, 2019
|
The commit checker is failing because two of the commits have bad commit messages. I'd recommend just squashing the two later commits into the first, and keeping the first commit message. After squashing locally, just force-push to your branch on Github, this gets handled correctly by the PR. |
LordAro
approved these changes
Jun 6, 2019
|
I believe the currency code of the New Taiwan dollar should be TWD rather than NTD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As titled, NTD, CNY, HKD are popular currencies in Chinese-speaking area. But there're no currencies there, so I added these currencies.
Another question: Can I translate something by editing
src/lang/xx.txt?