Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add:Three currencies: NTD, CNY, HKD #7596

Merged
merged 1 commit into from Jun 9, 2019
Merged

Conversation

iigmir
Copy link
Contributor

@iigmir iigmir commented May 16, 2019

As titled, NTD, CNY, HKD are popular currencies in Chinese-speaking area. But there're no currencies there, so I added these currencies.

Another question: Can I translate something by editing src/lang/xx.txt?

@glx22
Copy link
Contributor

@glx22 glx22 commented May 17, 2019

Translations are made via http://translator.openttd.org/

src/currency.h Outdated Show resolved Hide resolved
Copy link
Contributor

@nielsmh nielsmh left a comment

Translations should always be made via the web translator. Please remove the changes to simplified_chinese.txt and traditional_chinese.txt from this PR.

nielsmh
nielsmh previously approved these changes May 24, 2019
@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented May 24, 2019

The commit checker is failing because two of the commits have bad commit messages. I'd recommend just squashing the two later commits into the first, and keeping the first commit message. After squashing locally, just force-push to your branch on Github, this gets handled correctly by the PR.

LordAro
LordAro approved these changes Jun 6, 2019
@nielsmh nielsmh merged commit 5b09323 into OpenTTD:master Jun 9, 2019
8 checks passed
@hpiirai
Copy link

@hpiirai hpiirai commented Jun 9, 2019

I believe the currency code of the New Taiwan dollar should be TWD rather than NTD.
See Wikipedia: New Taiwan dollar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants