Repository navigation
Fix #7593: Crash in ScriptOrder::GetOrderDistance in VT_AIR mode - #7605
Merged
LordAro merged 1 commit intoJul 22, 2019
Merged
Conversation
LordAro
previously requested changes
Jun 6, 2019
LordAro
left a comment
Member
There was a problem hiding this comment.
That if statement is getting a bit long, can you separate it into a couple of temporaries? origin_station & dest_station, probably
LordAro
force-pushed
the
get-order-distance-waypoint-fix
branch
from
July 7, 2019 15:34
ba6b6c3 to
3bea58b
Compare
glx22
previously approved these changes
Jul 7, 2019
glx22
reviewed
Jul 7, 2019
Null pointer dereference occurred when either origin_tile or dest_tile were waypoint tiles.
LordAro
force-pushed
the
get-order-distance-waypoint-fix
branch
from
July 7, 2019 15:48
3bea58b to
aa53935
Compare
glx22
approved these changes
Jul 7, 2019
glx22
left a comment
Contributor
There was a problem hiding this comment.
Now it should be correct :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Null pointer dereference occurred when either origin_tile or dest_tile
were waypoint tiles.