Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7593: Crash in ScriptOrder::GetOrderDistance in VT_AIR mode #7605

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@JGRennison
Copy link
Contributor

@JGRennison JGRennison commented May 23, 2019

Null pointer dereference occurred when either origin_tile or dest_tile
were waypoint tiles.

LordAro
LordAro previously requested changes Jun 6, 2019
Copy link
Member

@LordAro LordAro left a comment

That if statement is getting a bit long, can you separate it into a couple of temporaries? origin_station & dest_station, probably

@LordAro LordAro force-pushed the get-order-distance-waypoint-fix branch from ba6b6c3 to 3bea58b Jul 7, 2019
@LordAro LordAro dismissed their stale review Jul 7, 2019

fixed it myself

glx22
glx22 previously approved these changes Jul 7, 2019
src/script/api/script_order.cpp Outdated Show resolved Hide resolved
@glx22 glx22 dismissed their stale review Jul 7, 2019

was too fast to click

Null pointer dereference occurred when either origin_tile or dest_tile
were waypoint tiles.
@LordAro LordAro force-pushed the get-order-distance-waypoint-fix branch from 3bea58b to aa53935 Jul 7, 2019
glx22
glx22 approved these changes Jul 7, 2019
Copy link
Contributor

@glx22 glx22 left a comment

Now it should be correct :)

@LordAro LordAro merged commit d71a7c2 into OpenTTD:master Jul 22, 2019
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants