Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Town name filtering #7621

Merged
merged 2 commits into from Jul 22, 2019

Conversation

@telk5093
Copy link
Contributor

commented Jun 12, 2019

This is a re-PR of #6983, which implements the filtering feature for town name list like below:
(I reopen a PR since I have no idea how to change branch of previous PR)
image

Now it does not blink and seems stable unlike #6983 as @LordAro said.
Nevertheless, please let me know if there any problem with my commit and also please aware that I'm very new to both C/C++ and OpenTTD's codes.

src/town_gui.cpp Outdated Show resolved Hide resolved

@telk5093 telk5093 force-pushed the telk5093:town_name_filtering branch 2 times, most recently from ff43701 to e75f752 Jun 13, 2019

@nielsmh

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Remember to run the generate_widget and squirrel_export scripts after adding a new widget ID, and commit the updated script API files.

src/town_gui.cpp Outdated Show resolved Hide resolved

@telk5093 telk5093 force-pushed the telk5093:town_name_filtering branch from 10b26e7 to 892c67c Jun 13, 2019

@telk5093

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

@nielsmh I had no idea I should run squirrel_export additionally. Thanks for noticing me and has done.

@telk5093 telk5093 force-pushed the telk5093:town_name_filtering branch from 892c67c to cd84304 Jun 13, 2019

@telk5093 telk5093 force-pushed the telk5093:town_name_filtering branch from cd84304 to 3054c49 Jun 13, 2019

@LordAro
LordAro approved these changes Jul 7, 2019

@LordAro LordAro merged commit 196d586 into OpenTTD:master Jul 22, 2019

8 checks passed

OpenTTD CI Build #20190613.6 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.