Fix warnings from GCC9 #7630
Merged
Fix warnings from GCC9 #7630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
force-pushed
the
gcc9-warningfix
branch
2 times, most recently
from
c9d285d to
ec4c4ac
Compare
|
clang build now relies on OpenTTD/CompileFarm#37 |
LordAro
force-pushed
the
gcc9-warningfix
branch
2 times, most recently
from
8cc3633 to
3bbcdb8
Compare
LordAro
force-pushed
the
gcc9-warningfix
branch
from
3bbcdb8 to
4cc611c
Compare
|
👍 looks good on my gcc 9.2.1 on Debian. |
nielsmh
reviewed
Sep 7, 2019
LordAro
force-pushed
the
gcc9-warningfix
branch
from
4cc611c to
e476f2b
Compare
glx22
reviewed
Sep 28, 2019
There was a problem hiding this comment.
I really don't see how to fix
/home/vsts/work/1/s/src/script/api/script_goal.cpp:141:36: warning: comparison of constant 65536 with expression of type 'ScriptClient::ClientID' is always true [-Wtautological-constant-out-of-range-compare]
EnforcePrecondition(false, client < (1 << 16));
~~~~~~ ^ ~~~~~~~~~
/home/vsts/work/1/s/src/script/api/script_error.hpp:24:8: note: expanded from macro 'EnforcePrecondition'
if (!(condition)) { \
^~~~~~~~~
| @@ -38,7 +38,7 @@ enum NetworkVehicleType { | |||
| }; | |||
|
|
|||
| /** 'Unique' identifier to be given to clients */ | |||
| enum ClientID { | |||
| enum ClientID : uint32 { | |||
| @@ -26,7 +26,7 @@ class ScriptClient : public ScriptObject { | |||
| public: | |||
|
|
|||
| /** Different constants related to ClientID. */ | |||
| enum ClientID { | |||
| enum ClientID : uint32 { | |||
|
I'd suggest that it does actually work, but the warning is invalid. Newer versions of clang (8, at least) don't display this warning. Would need to check the generated code to be sure, but none of our official binaries built using clang, and gcc doesn't use these "short" enums by default |
nielsmh
reviewed
Sep 29, 2019
…or (fixes warning from clang)
LordAro
force-pushed
the
gcc9-warningfix
branch
from
5912d47 to
d82a512
Compare
nielsmh
approved these changes
Sep 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noisest one is https://gcc.gnu.org/onlinedocs/gcc-9.1.0/gcc/C_002b_002b-Dialect-Options.html#index-Wdeprecated-copy
Mostly fixed by removing explicit copy constructors in favour of implicit compiler, or removing the need for one (switching an array out with std::array)
Closes #7748
Closes #7751