Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix warnings from GCC9 #7630
Conversation
c9d285d
to
ec4c4ac
This comment has been minimized.
This comment has been minimized.
clang build now relies on OpenTTD/CompileFarm#37 |
8cc3633
to
3bbcdb8
This comment has been minimized.
This comment has been minimized.
|
I really don't see how to fix
|
@@ -38,7 +38,7 @@ enum NetworkVehicleType { | |||
}; | |||
|
|||
/** 'Unique' identifier to be given to clients */ | |||
enum ClientID { | |||
enum ClientID : uint32 { |
This comment has been minimized.
This comment has been minimized.
@@ -26,7 +26,7 @@ class ScriptClient : public ScriptObject { | |||
public: | |||
|
|||
/** Different constants related to ClientID. */ | |||
enum ClientID { | |||
enum ClientID : uint32 { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'd suggest that it does actually work, but the warning is invalid. Newer versions of clang (8, at least) don't display this warning. Would need to check the generated code to be sure, but none of our official binaries built using clang, and gcc doesn't use these "short" enums by default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
LordAro commentedJun 29, 2019
•
edited
Noisest one is https://gcc.gnu.org/onlinedocs/gcc-9.1.0/gcc/C_002b_002b-Dialect-Options.html#index-Wdeprecated-copy
Mostly fixed by removing explicit copy constructors in favour of implicit compiler, or removing the need for one (switching an array out with std::array)
Closes #7748
Closes #7751