Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7633: Allow zero-cost track conversion to succeed #7634

Merged
merged 1 commit into from Jul 6, 2019

Conversation

@nielsmh
Copy link
Contributor

nielsmh commented Jul 1, 2019

Fix #7633 by keeping track of whether anything was actually converted at all, so conversion can succeed even when the final cost ends up zero.

@LordAro
Copy link
Member

LordAro commented Jul 1, 2019

Technically, should be "convertible"...

@nielsmh nielsmh force-pushed the nielsmh:bug7633 branch from 7cca7ea to fb03f6a Jul 6, 2019
@LordAro
LordAro approved these changes Jul 6, 2019
@nielsmh nielsmh merged commit 81614f2 into OpenTTD:master Jul 6, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190706.4 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@nielsmh
Copy link
Contributor Author

nielsmh commented Jul 6, 2019

If this gets backported, the road part obviously needs to be skipped since NRT isn't in 1.9 :)

@nielsmh nielsmh deleted the nielsmh:bug7633 branch Jul 6, 2019
michicc added a commit to michicc/OpenTTD that referenced this pull request Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.