Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Update for French town name "Beaujolais" #7654

Closed
wants to merge 1 commit into from

Conversation

@nikolas
Copy link
Member

@nikolas nikolas commented Jul 13, 2019

Pointed out by MagicBuzz here:
https://www.tt-forums.net/viewtopic.php?f=29&t=85567

There's no town in France called Beaujolais, but the current
name for the capital of the Beaujolais province is Villefranche-sur-Saône.

@nikolas
Copy link
Member Author

@nikolas nikolas commented Jul 13, 2019

The commit checker fails when there are non-ASCII characters in the commit message. Is that really a problem though? What's wrong with using unicode in git commits? I have no problem changing my commit, just seems annoying and unnecessary.

Pointed out by MagicBuzz here:
    https://www.tt-forums.net/viewtopic.php?f=29&t=85567

There's no town in France called Beaujolais, but the current
name for the capital of the Beaujolais province is Villefranche-sur-Saone.
@nikolas nikolas force-pushed the beaujolais-update branch from a3860c6 to a9c64c9 Jul 13, 2019
@LordAro
Copy link
Member

@LordAro LordAro commented Jul 14, 2019

I'm tempted to agree with the other posts in the forum thread - the original game had it that way, so it should stay that way (recent corrections to accents aside)

@Eddi-z
Copy link
Contributor

@Eddi-z Eddi-z commented Jul 14, 2019

IMHO we should create a method to hide the "legacy" townname generators (so they can only be used when loading old games) and supercede them with new ones

@nikolas
Copy link
Member Author

@nikolas nikolas commented Jul 15, 2019

There's a lot to be discussed here so I'll close this for now.

@nikolas nikolas closed this Jul 15, 2019
@planetmaker
Copy link
Contributor

@planetmaker planetmaker commented Jul 16, 2019

A fix to the old townname generators IMHO is not a bad thing as long as they only touch spelling. We did that before.

At the same time I think Eddi has a very fair point, and suggests the right approach. Along that approach my favourite procedure would be to ship some selected, curated townname NewGRFs which provide reasonably big amount of names alongside OpenTTD. This could possibly be solved similar to how base sets are handled during install.

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Jul 16, 2019

A way for GRFs only providing townnames to be perma-loaded similar to static NewGRFs could perhaps also help usability. As in, if scanning detects a NewGRF that only supplies townnames, it doesn't get offered in the NewGRF configuration for a game, but instead just appears in the town name options.
I don't know if that's actually possible.

@planetmaker
Copy link
Contributor

@planetmaker planetmaker commented Jul 16, 2019

It would not even need to be static. It would suffice to compile a list of townname-only NewGRFs and in the townname selection provide a list of townname lists they offer (a townname NewGRF can offer several set of townnames). Problem with my selection is that townname NewGRFs may (currently) have parameters which a user might want to set. Though I doubt that big damage is done when they simply all are set to 0 for this purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants