Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Rework 'start_date' parameter for AIs as a game setting #7661

Closed

Conversation

SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Jul 20, 2019

  • Moves 'start_date' AI parameter away from scripts losing its "per-AI" customization, into a game setting. It is now a "one for all" approach for the feature.
  • Retains the random deviation behaviour for nonzero values.
  • Now also displays Start Delay on AI/Game Script Config window
  • Allow the ability to enter values for both Max no. companies and Start Delay when clicking on their names inside the AI/Game Script Config window.
  • Start Delay defaults are based on the value of Settings Profile.
  • The means of handling default values of settings has thus been altered.

This attempts to redo the whole start_date thing to be more sane, understandable and predictable.

@SamuXarick SamuXarick force-pushed the rework-start_date-as-game-setting branch from 67cd896 to 468fd53 Compare Jul 21, 2019
@SamuXarick
Copy link
Contributor Author

@SamuXarick SamuXarick commented Jul 21, 2019

To do: STR_AI_SETTINGS_START_DELAY is no longer in use. Remove plz. Done.

SamuXarick added 3 commits Jul 12, 2020
- Moves 'start_date' AI parameter away from scripts losing its "per-AI" customization, into a game setting. It is now a "one or all" approach for the feature.
- Retains the random deviation behaviour for nonzero values.

This attempts to redo the whole start_date thing to be more sane, understandable and predictable.
…faults on 'settings_profile'

- Now also displays Start Delay on AI/Game Script Config window
- Allow the ability to enter values for both Max no. companies and Start Delay when clicking on their names inside the AI/Game Script Config window.
- Start Delay defaults are based on the value of Settings Profile.
- The means of handling default values of settings has thus been altered.
- STR_AI_SETTINGS_START_DELAY no longer in use.
@SamuXarick SamuXarick force-pushed the rework-start_date-as-game-setting branch from b2948f3 to 7265fcc Compare Jul 12, 2020
@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Dec 14, 2020

There has been so much talk about this .. and honestly, I am tired. Sorry, I am going to close this one. Not because it is a bad idea as such, but because the effort required for us to review this, based on the history. I can leave it open and act someone might look at it some day, but really, nobody will. Sorry about that. Please start with smaller well documented more clear described and tested PRs first, and build up from there. That helps us and you both.

@TrueBrain TrueBrain closed this Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants