Codechange: math functions - use cpp-style casts

[nikolas]

No description provided.

[glx22]

Of course commit checker fails because # should move to first column when the line is modified.
<tabs>#xxx must now be #<tabs>xxx

[nikolas]

Ah i see, i just found an old conversation about this here: #7407 (comment)

I'll make that change.

[glx22]

Please restore the indentation between # and define

[LordAro]

Not that I necessarily disagree with the changes, but I'd like to see some justification for them. What problem do they solve? How do they improve things?

[nikolas]

Using C++ style casts makes the intention of the code more explicit:

The problem with C casts is the ambiguity of the operation; sometimes you are doing a conversion (e.g., (int)3.5) and sometimes you are doing a cast (e.g., (int)"hello"). Brace initialization and C++ casts can often help avoid this ambiguity. Additionally, C++ casts are more visible when searching for them.

From: https://google.github.io/styleguide/cppguide.html#Casting

That said, maybe this should be an all-or-nothing style decision. C++ casts could be used everywhere if that's decided to be an improvement, otherwise just keep everything as it is.

[LordAro]

According to https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html, the cast to int32 is unnecessary (or possibly wrong)

[LordAro]

Close enough