Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub sponsors button to feature donations page #7700

Merged
merged 1 commit into from Aug 31, 2019

Conversation

@rogersachan
Copy link
Contributor

commented Aug 17, 2019

Changes proposed in this request:

.github/FUNDING.yml shows the community how to support this project. Please see our repository funding links [documentation ](https://help.github.com/en/articles/displaying-a-sponsor-button-in-your-repository) for more information on formatting and what is and isn't allowed in this file.

Please note that funding links are currently disabled on this repository. Visit repository settings to enable display of your funding links.

This button needs to be enabled from the repo settings, and after that this pull request can be merged.

@LordAro

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

Thanks for adding this, but can you fix the commit message? Our CI is very particular about commit messages! I'd suggest Add: [GitHub] FUNDING.yml

@TrueBrain TrueBrain merged commit 1be42c6 into OpenTTD:master Aug 31, 2019

6 of 8 checks passed

OpenTTD CI Build #20190817.5 failed
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker failed
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@TrueBrain

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

I fixed the issue for you during squashing ;) Nice suggestion, tnx!

@rogersachan rogersachan deleted the rogersachan:patch-1 branch Aug 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.