Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesPrepare for 1.9.3 release candidate #7723
Conversation
CompanyID is 8 bit wide, so this incorrect cast would make it impossible to create story page elements for pages past 255.
…ror message as it should be.
Sending order command to an industry tile now checks if a neutral_station is available and sends the order to that station
This comment has been minimized.
This comment has been minimized.
…ads owned by towns (instead of crashing).
|
Seems ok to me, but maybe wait for another review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nielsmh commentedSep 6, 2019
•
edited
Two major issues for the macOS version are the primary reason for this release, but there are also a few other minor fixes/improvements that can be included.