Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 1.9.3 release candidate #7723

Merged
merged 12 commits into from Sep 7, 2019
Merged

Conversation

@nielsmh
Copy link
Contributor

nielsmh commented Sep 6, 2019

Two major issues for the macOS version are the primary reason for this release, but there are also a few other minor fixes/improvements that can be included.

  • #7657 Could not create elements on Storybook pages with ID > 255
  • #7669 Decrease buttons in Cheat window not working with UI scaling
  • #7686 Spelling error
  • #7690 Better error message demolishing an occupied airport
  • #7705 OSX crash sorting malformed UTF-8 strings
  • #7709 Easier to make orders to industry neutral stations (this one is actually entirely rewritten)
  • #7714 Highscore screen scaling
  • #7627 Allow building road stops over town-owned one-way roads, instead of crashing
  • #7701 & #7725 Crash in AI in multiplayer if reloaded while waiting for a command return
  • #7721 OSX colourspace conversion causing bad performance
nielsmh and others added 7 commits Jul 17, 2019
CompanyID is 8 bit wide, so this incorrect cast would make it impossible to create story page elements for pages past 255.
Sending order command to an industry tile now checks if a neutral_station is available and sends the order to that station
@nielsmh

This comment has been minimized.

Copy link
Contributor Author

nielsmh commented Sep 6, 2019

Looking at these changes a little closer, it seems that apart from #7657 and #7701 the remaining changes should be network compatible with 1.9.2, although I'm not entirely sure about the airport #7690 either.

@nielsmh nielsmh force-pushed the nielsmh:rel-1.9.3 branch from 1fcbcb8 to a481042 Sep 7, 2019
@nielsmh nielsmh force-pushed the nielsmh:rel-1.9.3 branch from a481042 to 1be829b Sep 7, 2019
@nielsmh nielsmh force-pushed the nielsmh:rel-1.9.3 branch from 1be829b to ca22240 Sep 7, 2019
@nielsmh nielsmh marked this pull request as ready for review Sep 7, 2019
@nielsmh nielsmh force-pushed the nielsmh:rel-1.9.3 branch from ca22240 to f5d3a97 Sep 7, 2019
@nielsmh nielsmh changed the title Prepare for release 1.9.3 Prepare for 1.9.3 release candidate Sep 7, 2019
os/debian/changelog Outdated Show resolved Hide resolved
@nielsmh nielsmh force-pushed the nielsmh:rel-1.9.3 branch from f5d3a97 to 13a6b9a Sep 7, 2019
@nielsmh nielsmh force-pushed the nielsmh:rel-1.9.3 branch from 13a6b9a to edf705a Sep 7, 2019
Copy link
Contributor

glx22 left a comment

Seems ok to me, but maybe wait for another review

@LordAro
LordAro approved these changes Sep 7, 2019
@glx22
glx22 approved these changes Sep 7, 2019
@LordAro LordAro merged commit e5021a0 into OpenTTD:release/1.9 Sep 7, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190907.21 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.