Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use natural sort when sorting the file list. #7727

Merged
merged 1 commit into from Sep 8, 2019

Conversation

@j-pet
Copy link
Contributor

j-pet commented Sep 7, 2019

Current sorting of the list of files does work incorrectly (at least on Windows OS). See images below.

Incorrect sorting in example of the Cyrillic chars:

Current (incorrect) With this fix (correct)
sort_letters old sort_letters new

Also a nice addition is the sorting of numbers:

Current With this fix
sort_numbers old sort_numbers new
@nielsmh
nielsmh approved these changes Sep 8, 2019
@nielsmh nielsmh merged commit 7bdde8b into OpenTTD:master Sep 8, 2019
8 checks passed
8 checks passed
OpenTTD CI Build #20190907.17 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.8) Linux linux-amd64-clang-3.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@j-pet j-pet deleted the j-pet:Fix_sorting branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.