Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add #7525: Allow autoreplace with same model vehicle #7729

Open
wants to merge 2 commits into
base: master
from

Conversation

@nielsmh
Copy link
Contributor

nielsmh commented Sep 8, 2019

This is not what #7525 asks for, but I think it's just as good, or better. Remove the old restriction on autoreplacing vehicles with the same model, but instead add a check so autoreplace with same model only ever occurs when the vehicle is nearing end of life.

@ldpl

This comment has been minimized.

Copy link
Contributor

ldpl commented Sep 8, 2019

There is actually a use for autoreplacing with same model before the end of life. Because of stupid cargo rating calculations it's sometimes beneficial to just autoreplace everything every few years.
Also makes me wonder if it's possible for newgrf to make a vehicle with such a short life that it will constantly autoreplace with this patch xD

@Eddi-z

This comment has been minimized.

Copy link
Contributor

Eddi-z commented Sep 8, 2019

i'd say we should rather change that rating calculation, like give the boost only to vehicles bought in the prototype phase

@nielsmh

This comment has been minimized.

Copy link
Contributor Author

nielsmh commented Sep 8, 2019

Or change it so the effect diminishes based on years from vehicle model introduction date.

@Eddi-z

This comment has been minimized.

Copy link
Contributor

Eddi-z commented Sep 8, 2019

... the details are open for discussion, but i think we should rather fix an exploit rather than design game mechanics to facilitate them.

@nielsmh

This comment has been minimized.

Copy link
Contributor Author

nielsmh commented Sep 8, 2019

Well I did a separate PR to fix that exploit then, #7730 :)

@LordAro

This comment has been minimized.

Copy link
Member

LordAro commented Oct 25, 2019

I feel like there's some helptext somewhere that could be expanded with this fact...

@nielsmh

This comment has been minimized.

Copy link
Contributor Author

nielsmh commented Dec 1, 2019

Also to clarify: This PR does not enable the above exploit. It protects against it by converting any "replace now" into "replace when old" when the replacement vehicle is the same model. Of course that doesn't prevent the player from manually doing a "replace all vehicles now" to a similar model once every year or two.

@nielsmh nielsmh added this to the 1.10.0 milestone Jan 12, 2020
@LordAro

This comment has been minimized.

Copy link
Member

LordAro commented Jan 12, 2020

Can you explain (again) why autoreplace with same engine (when old) is different/beneficial to autorenew? To me it just seems like adding a 2nd (confusing) way of doing the same thing

@nielsmh

This comment has been minimized.

Copy link
Contributor Author

nielsmh commented Jan 12, 2020

I see two advantages, one is that it might be easier to discover. It doesn't require digging around in the Settings UI. (I haven't been able to think of a good place to put the auto-renew option in the regular GUI.)
The other is that it more directly lets the player be selective about which vehicles they want to renew.

@sheepo99

This comment has been minimized.

Copy link

sheepo99 commented Jan 12, 2020

Agreed with @nielsmh. Autoreplace and autorenew should be same, since they do practically the same function that is replacing vehicles, whether it is a different one or the same. That one has to navigate into the settings menu to activate specifically autorenew is highly user unfriendly and confusing to new players alike.

@LordAro

This comment has been minimized.

Copy link
Member

LordAro commented Jan 13, 2020

So perhaps autorenew should be removed/deprecated/converted in favour of this?

@auge8472

This comment has been minimized.

Copy link
Contributor

auge8472 commented Jan 13, 2020

Can you explain (again) why autoreplace with same engine (when old) is different/beneficial to autorenew? To me it just seems like adding a 2nd (confusing) way of doing the same thing

For me it is confusing not to be able to replace a vehicle with a new vehicle of the same type in the same way as replacing the vehicle with another one of a different type. There is technically no difference except for the type I want to replace the vehicle with. So the similar handling of both cases is IMHO an advantage.

So perhaps autorenew should be removed/deprecated/converted in favour of this?

There is a difference in the way the functions work. With "autorenew" all vehicles get replaced with the same type when they get old. For (classic) autoreplace you as the player have to take action. Maybe the functions are mergable so that one can set autorenew (or not) but can override it in the autoreplace-GUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.