Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier access for vehicles' group window. #7800

Merged
merged 5 commits into from Dec 23, 2019

Conversation

@stormcone
Copy link
Contributor

stormcone commented Oct 25, 2019

This is the follow-up PR of #7582.

I changed the shift+click combinations to control+click, removed the right click options from the vehicle news window, and added the functionality to the vehicle lists windows also.

I as well moved the button from the bottom of the vehicle news window to the caption bar, because I am not really liked the way it looked.
vehicle_news

@andythenorth
Copy link
Contributor

andythenorth commented Oct 25, 2019

I tested this briefly. Shared order vehicle lists / station vehicle list are remarkably improved by the ctrl-click behaviour 😄

I'm not sure about the icon on the order warning: I tried it, but I didn't have any opinion whether it's an improvement, nor did I test it for edge cases etc I'll leave it to someone else to decide if that button is in scope or not, but the ctrl-click behaviour should definitely be merged IMHO.

@stormcone
Copy link
Contributor Author

stormcone commented Oct 25, 2019

I mainly put the button on the vehicle news window for the old vehicle notifications. I usually replace the vehicles only when they getting old and can not be "autorenewed". So in that case easier to open the group window with the button.

@stormcone stormcone force-pushed the stormcone:shitf-click-group branch from 46d6754 to 96ab06c Nov 23, 2019
Copy link
Member

LordAro left a comment

Nothing significant. Looks good!

src/group_gui.cpp Show resolved Hide resolved
src/group_gui.cpp Outdated Show resolved Hide resolved
src/group_gui.cpp Outdated Show resolved Hide resolved
src/lang/english.txt Outdated Show resolved Hide resolved
src/news_gui.cpp Outdated Show resolved Hide resolved
@stormcone stormcone force-pushed the stormcone:shitf-click-group branch from 96ab06c to 62b3543 Nov 28, 2019
stormcone added 5 commits May 10, 2019
… view window opens the vehicle group window, then selects and scrolls to the vehicle's group.
…pens the vehicle group window focused on the vehicle's group.
@stormcone stormcone force-pushed the stormcone:shitf-click-group branch from 62b3543 to d8e6f79 Dec 16, 2019
@stormcone stormcone requested a review from LordAro Dec 16, 2019
@LordAro LordAro merged commit fea5151 into OpenTTD:master Dec 23, 2019
8 checks passed
8 checks passed
OpenTTD CI #20191216.4 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.9) Linux linux-amd64-clang-3.9 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@stormcone stormcone deleted the stormcone:shitf-click-group branch Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.