Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier access for vehicles' group window. #7800

merged 5 commits into from Dec 23, 2019


Copy link

This is the follow-up PR of #7582.

I changed the shift+click combinations to control+click, removed the right click options from the vehicle news window, and added the functionality to the vehicle lists windows also.

I as well moved the button from the bottom of the vehicle news window to the caption bar, because I am not really liked the way it looked.

Copy link

andythenorth commented Oct 25, 2019

I tested this briefly. Shared order vehicle lists / station vehicle list are remarkably improved by the ctrl-click behaviour 😄

I'm not sure about the icon on the order warning: I tried it, but I didn't have any opinion whether it's an improvement, nor did I test it for edge cases etc I'll leave it to someone else to decide if that button is in scope or not, but the ctrl-click behaviour should definitely be merged IMHO.

Copy link
Contributor Author

I mainly put the button on the vehicle news window for the old vehicle notifications. I usually replace the vehicles only when they getting old and can not be "autorenewed". So in that case easier to open the group window with the button.

Copy link

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing significant. Looks good!

src/group_gui.cpp Show resolved Hide resolved
src/group_gui.cpp Outdated Show resolved Hide resolved
src/group_gui.cpp Outdated Show resolved Hide resolved
src/lang/english.txt Outdated Show resolved Hide resolved
src/news_gui.cpp Outdated Show resolved Hide resolved
… view window opens the vehicle group window, then selects and scrolls to the vehicle's group.
…pens the vehicle group window focused on the vehicle's group.
@LordAro LordAro merged commit fea5151 into OpenTTD:master Dec 23, 2019
@stormcone stormcone deleted the shitf-click-group branch February 15, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants