Feature: Minimap screenshot #7817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGRennison
added a commit
to JGRennison/Upstream-OpenTTD
that referenced
this pull request
Nov 2, 2019
|
I like it, but I feel like it would be better implemented as a separate "screenshot mode". This would ensure no issues with overwriting files. Shouldn't mean many changes in the core functionality you've implemented |
telk5093
changed the title
|
I think you intended like this new code. Now it is unifyed with |
telk5093
force-pushed
the
minimap
branch
2 times, most recently
from
1ad5f9e
to
94d2c9b
Compare
LordAro
requested changes
Nov 23, 2019
telk5093
changed the title
LordAro
requested changes
Nov 27, 2019
|
I applied recent /pull/7550's changes, please look around. Sorry for my pool coding skill beforehand :) |
LordAro
requested changes
Jan 4, 2020
|
Thanks for your advices, please check if I've done correctly. |
LordAro
approved these changes
Jan 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This command is introduced at this tt-forum post and already implemented in JGRPP as
minimap owner <file_name>This feature extends
screenshotcommand to take top-viewed screenshot asscreenshot topview.Its output looks like this (from title game):
And adds a dropdown menu:
eg)
screenshot minimapscreenshot minimap <filename>Most part of this code is not from me, but from here.
I have no idea if I dare could make a PR although its original author is not me.
Please let me know if it is not allowed or there is any problem.
Btw, it is quite useful command to show users server's status via website.
I am using JGRPP's
minimapcommand to show my server's status in my website