Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix c02ef3e456: Special case of Var 0x88 was not handled for NRT Acti… #7823

Open
wants to merge 2 commits into
base: master
from

Conversation

@Eddi-z
Copy link
Contributor

Eddi-z commented Nov 3, 2019

…on 7 conditions

@Eddi-z Eddi-z force-pushed the Eddi-z:nrt-fix branch from 642dae1 to 024dcad Nov 3, 2019
@Eddi-z
Copy link
Contributor Author

Eddi-z commented Nov 3, 2019

it's a bit unclear why there are 4 condition types for NRT checks, seems 2 would be enough

@Eddi-z Eddi-z force-pushed the Eddi-z:nrt-fix branch from 024dcad to 7c9bc73 Nov 3, 2019
…hecks from Action 7
@@ -6630,10 +6632,6 @@ static void SkipIf(ByteReader *buf)
break;
case 0x10: result = GetRoadTypeByLabel(BSWAP32(cond_val)) != INVALID_ROADTYPE;
break;
case 0x11: result = GetRoadTypeByLabel(BSWAP32(cond_val)) == INVALID_ROADTYPE;
break;

This comment has been minimized.

Copy link
@frosch123

frosch123 Nov 3, 2019

Member

I think this stuff is correct and should be kept.
There are also separate translation tables for road and tram.

But who knows.

This comment has been minimized.

Copy link
@Eddi-z

Eddi-z Nov 3, 2019

Author Contributor

If they should be kept as a separation between Road and Tram, they should probably be extended with actually different checks.

@LordAro LordAro dismissed their stale review Nov 14, 2019

defer to frosch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.