Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix c02ef3e456: Special case of Var 0x88 was not handled for NRT Acti… #7823

Closed
wants to merge 2 commits into from

Conversation

@Eddi-z
Copy link
Contributor

@Eddi-z Eddi-z commented Nov 3, 2019

…on 7 conditions

@Eddi-z
Copy link
Contributor Author

@Eddi-z Eddi-z commented Nov 3, 2019

it's a bit unclear why there are 4 condition types for NRT checks, seems 2 would be enough

LordAro
LordAro previously approved these changes Nov 3, 2019
@@ -6630,10 +6632,6 @@ static void SkipIf(ByteReader *buf)
break;
case 0x10: result = GetRoadTypeByLabel(BSWAP32(cond_val)) != INVALID_ROADTYPE;
break;
case 0x11: result = GetRoadTypeByLabel(BSWAP32(cond_val)) == INVALID_ROADTYPE;
break;
Copy link
Member

@frosch123 frosch123 Nov 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this stuff is correct and should be kept.
There are also separate translation tables for road and tram.

But who knows.

Copy link
Contributor Author

@Eddi-z Eddi-z Nov 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they should be kept as a separation between Road and Tram, they should probably be extended with actually different checks.

@frosch123
Copy link
Member

@frosch123 frosch123 commented Dec 15, 2020

Part of this was already fixed in 7f351fd.
The rest is incorporated into #8382.

@frosch123 frosch123 closed this Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants