Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix #7847: Use ViewportSign coordinates for sign Kdtree coordinates #7849
Fix #7847 by ensuring the same coordinates are used for a station sign regardless of how the landscape changes below it after the coordinates were first determined.
By keeping track of whether the ViewportSign is valid for Kdtree use (and only ever registering the station viewport sign when the sign object is valid) a lot of code can be simplified, and it should prevent a lot of similar bugs too.
I think this is the real solution to all Kdtree bugs regarding station signs. I think something similar needs to be done for town names and player signs too.
…or stations Keeping track of whether the ViewportSign data are valid for Kdtree usage allows moving more housekeeping to Station::UpdateVirtCoord and Waypoint::UpdateVirtCoord and helps simplify a lot of other code.
…ions It's the more correct approach, it was only not usable before due to inconsistencies with when sign positions were updated.