Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: [hotkeys] add missing keycodes for hotkeys.cfg #7850

Open
wants to merge 1 commit into
base: master
from

Conversation

@grossws
Copy link

grossws commented Dec 1, 2019

Added missing keycodes mapping to _keycode_to_name array
to allow their use in hotkeys.cfg.

Also reordered them according to WindowKeyCodes order.

Signed-off-by: Konstantin Gribov grossws@gmail.com

Added missing keycodes mapping to `_keycode_to_name` array
to allow their use in `hotkeys.cfg`.

Also reordered them according to `WindowKeyCodes` order.

Signed-off-by: Konstantin Gribov <grossws@gmail.com>
{"]", WKC_R_BRACKET},
{"'", WKC_SINGLEQUOTE},
{",", WKC_COMMA},
{"COMMA", WKC_COMMA}, // legacy variant, should be below ","

This comment has been minimized.

Copy link
@LordAro

LordAro Dec 2, 2019

Member

why this addition?

This comment has been minimized.

Copy link
@grossws

grossws Dec 2, 2019

Author

, is just for consistency with existing -/= and new //;/etc. And COMMA to support configs from previous versions. Maybe it would be better to support it in config reading instead of this hack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.