Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: [hotkeys] add missing keycodes for hotkeys.cfg #7850

Merged
merged 1 commit into from Dec 27, 2019

Conversation

@grossws
Copy link
Contributor

@grossws grossws commented Dec 1, 2019

Added missing keycodes mapping to _keycode_to_name array
to allow their use in hotkeys.cfg.

Also reordered them according to WindowKeyCodes order.

Signed-off-by: Konstantin Gribov grossws@gmail.com

Added missing keycodes mapping to `_keycode_to_name` array
to allow their use in `hotkeys.cfg`.

Also reordered them according to `WindowKeyCodes` order.

Signed-off-by: Konstantin Gribov <grossws@gmail.com>
{"]", WKC_R_BRACKET},
{"'", WKC_SINGLEQUOTE},
{",", WKC_COMMA},
{"COMMA", WKC_COMMA}, // legacy variant, should be below ","
Copy link
Member

@LordAro LordAro Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this addition?

Copy link
Contributor Author

@grossws grossws Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, is just for consistency with existing -/= and new //;/etc. And COMMA to support configs from previous versions. Maybe it would be better to support it in config reading instead of this hack

@LordAro LordAro merged commit 69f9529 into OpenTTD:master Dec 27, 2019
8 checks passed
douiwby added a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
Added missing keycodes mapping to `_keycode_to_name` array
to allow their use in `hotkeys.cfg`.

Also reordered them according to `WindowKeyCodes` order.

Signed-off-by: Konstantin Gribov <grossws@gmail.com>
spnda added a commit to spnda/OpenTTD that referenced this issue Jun 17, 2020
Added missing keycodes mapping to `_keycode_to_name` array
to allow their use in `hotkeys.cfg`.

Also reordered them according to `WindowKeyCodes` order.

Signed-off-by: Konstantin Gribov <grossws@gmail.com>
@grossws grossws deleted the change-hotkeys branch Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants