Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show the name of the NewGRF in the build vehicle window. #7852

Merged
merged 1 commit into from Jan 4, 2020

Conversation

@stormcone
Copy link
Contributor

@stormcone stormcone commented Dec 2, 2019

I am usually using couple of vehicle sets, mainly road vehicles, and I like to know which vehicle comes from which NewGRF. So I can use buses/truck from the same set in a town or region. Furthermore I can see which set's vehicles I am using frequently or rarely, so I can keep or remove it from my next game. You can enable or disable this feature in the settings. I put it among the advanced settings, because most players probably are not interested in this. But as you can see in the forum, at least one is interested. :)
newgrf_name_1
newgrf_name_2

@LordAro
Copy link
Member

@LordAro LordAro commented Dec 24, 2019

I like it, though I wouldn't personally bother with the setting

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Dec 27, 2019

Agree, there's no need for the setting, just show always.

@stormcone stormcone force-pushed the stormcone:show-newgrf-name branch from 4def6cf to 30ff53b Dec 27, 2019
@stormcone
Copy link
Contributor Author

@stormcone stormcone commented Dec 27, 2019

I removed the setting part. (Actually I added it only for this PR, I also have been using it for years without the setting part.)

@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Dec 28, 2019

I'd rather not have the text there all the time, I play on a small screen and more info text will cause the vehicle part of the buy menu to be physically smaller due to height constraint.

i.e. showing this text increases noise-signal ratio for a very marginal case.

Just my £0.02

One place that does notably the lack the newgrf name is the newgrf debug window for vehicles. Separate issue though.

@LordAro
Copy link
Member

@LordAro LordAro commented Dec 28, 2019

I wonder if having it just as a tooltip (over the "Designed" line?) might be sufficient. Or is that too hidden?

@stormcone
Copy link
Contributor Author

@stormcone stormcone commented Dec 28, 2019

I think the tooltip indeed would be too hidden. And if you are choosing between the vehicles you should always move the cursor and wait/right click for the tooltip to show up, and it's not comfortable.

So should I put back the setting?

@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Dec 29, 2019

So should I put back the setting?

Please :)

Generally I am -1 to settings, it's more combinatorial things to go wrong.

But there is already a lot of text info shown for vehicles, so I think this one is valid as a setting.
buy_menu_info

^ that's the purchase menu filling full height of my 13" screen, I would rather not lose more vehicles from it :)

@stormcone stormcone force-pushed the stormcone:show-newgrf-name branch from 30ff53b to 0e35698 Dec 29, 2019
@stormcone
Copy link
Contributor Author

@stormcone stormcone commented Dec 29, 2019

Please :)

Done. :)

src/lang/english.txt Outdated Show resolved Hide resolved
@stormcone stormcone force-pushed the stormcone:show-newgrf-name branch from 0e35698 to b7523a7 Dec 29, 2019
@stormcone stormcone requested a review from nielsmh Dec 29, 2019
@nielsmh nielsmh merged commit b524f1a into OpenTTD:master Jan 4, 2020
8 checks passed
8 checks passed
OpenTTD CI Build #20191229.6 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.9) Linux linux-amd64-clang-3.9 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@stormcone stormcone deleted the stormcone:show-newgrf-name branch Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.