Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Infrastructure total update when removing tram road stop #7856

Merged

Conversation

@JGRennison
Copy link
Contributor

JGRennison commented Dec 8, 2019

The wrong road owner was used when updating the tram infrastructure total.
This could result in desyncs, negative infrastructure totals, etc.

Reproduction steps:

  1. Build a tram stop
  2. Remove the tram stop
  3. Demolish the tram tracks
    You now have -2 tram tracks
The wrong road owner was used when updating the tram infrastructure total.
This could result in desyncs, negative infrastructure totals, etc.
@LordAro
LordAro approved these changes Dec 8, 2019
Copy link
Member

LordAro left a comment

Good ol' copy & paste error

@michicc michicc merged commit 35dc377 into OpenTTD:master Dec 8, 2019
8 checks passed
8 checks passed
OpenTTD CI #20191208.1 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.9) Linux linux-amd64-clang-3.9 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@JGRennison JGRennison deleted the JGRennison:fix-tram-road-stop-remove-infra-totals branch Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.