Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: TerraGenesis was not generating maps at the requested maximum height #7875

Closed

Conversation

@SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Dec 23, 2019

  • Maps were being generated with a maximum height one level lower than intended

I used a game script to check max height that was being generated.
Minimal GS-v2.zip

On Original generator, setting a max height of 15, generates a map with max height of 15.
mdOEDVP - Imgur

On TerraGenesis generator, setting a max height of 15, generates a map with max height of 14.
E4VjbWC - Imgur

…ight

- Maps were being generated with a maximum height one level lower than intended
@frosch123
Copy link
Member

@frosch123 frosch123 commented Dec 23, 2019

This looks like you add a bug.
Please explain how TGPGetMaxHeight returning max_height+1 fixes something.

Also, a GS testing for maximum map height is no valid reason that this patch is correct. Programming is not about trial and error.

@SamuXarick
Copy link
Contributor Author

@SamuXarick SamuXarick commented Dec 23, 2019

This looks like you add a bug.
Please explain how TGPGetMaxHeight returning max_height+1 fixes something.
Also, a GS testing for maximum map height is no valid reason that this patch is correct. Programming is not about trial and error.

Sorry, I added a bug, seems that the other also needs to be included, brb.

@frosch123 frosch123 closed this Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.