Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6452: Reset only editable and visible settings from GUI #7890

Open
wants to merge 1 commit into
base: master
from

Conversation

@SamuXarick
Copy link
Contributor

SamuXarick commented Jan 1, 2020

Also enables the Reset button while in-game for AI configs.

@@ -310,8 +310,6 @@ struct AISettingsWindow : public Window {
this->vscroll = this->GetScrollbar(WID_AIS_SCROLLBAR);
this->FinishInitNested(slot); // Initializes 'this->line_height' as side effect.

this->SetWidgetDisabledState(WID_AIS_RESET, _game_mode != GM_MENU && Company::IsValidID(this->slot));

This comment has been minimized.

Copy link
@LordAro

LordAro Jan 18, 2020

Member

What is this change doing here?

This comment has been minimized.

Copy link
@SamuXarick

This comment has been minimized.

Copy link
@LordAro

LordAro Jan 18, 2020

Member

ok... why? Does it work? Why is it a good idea?

This comment has been minimized.

Copy link
@SamuXarick

SamuXarick Jan 19, 2020

Author Contributor

Because otherwise it is disabled.
Unnamed, 1951-02-23
It works!
Unnamed, 1951-03-04
Because AIs have this button disabled while in a game.

@SamuXarick SamuXarick force-pushed the SamuXarick:reset-ai-gs-non-anchored-settings branch from b9d7efd to 4b421e7 Feb 9, 2020
Also enables the Reset button while in-game for AI configs.
@SamuXarick SamuXarick force-pushed the SamuXarick:reset-ai-gs-non-anchored-settings branch from 4b421e7 to def2d1f May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.