Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Savegame regression testing #7895

Open
wants to merge 4 commits into
base: master
from
Open

Conversation

@LordAro
Copy link
Member

LordAro commented Jan 3, 2020

No description provided.

@LordAro LordAro force-pushed the LordAro:savegame-testing branch 3 times, most recently from c0e7ff1 to 676c008 Jan 3, 2020
@LordAro LordAro force-pushed the LordAro:savegame-testing branch from 676c008 to 7b69d13 Jan 3, 2020
@LordAro LordAro marked this pull request as ready for review Jan 3, 2020
@LordAro
Copy link
Member Author

LordAro commented Jan 3, 2020

Any suggestions for other savegames to add?

@nielsmh
Copy link
Contributor

nielsmh commented Jan 3, 2020

Perhaps the crazy 50k stations save?

I assume there can be problems with games that require NewGRFs, since not all are freely redistributable, and they can also be quite large. Perhaps have a feature to point to a suite of "private" additional games to test on? That can allow anyone to have their own selection of favorites, or games selected as relevant for their current work. It can also let us run extended regressions as part of CI, with a large library of games and GRFs that may not all be free for us to put in the main repository.

@LordAro
Copy link
Member Author

LordAro commented Jan 3, 2020

The 50k stations save is more for benchmarking, rather than any regression reasons - it doesn't have any other useful features!

As for GRFs - depends on the particular save. There are certainly saves (like #1131) where the crashing behaviour is independent of the GRFs, so the missing GRFs can be safely ignored. Not sure it's be particularly useful to separate them out into a separate repo.

@LordAro
Copy link
Member Author

LordAro commented Jan 3, 2020

Also I'd quite like to avoid bloating the repo more than necessary - 1MB per save is quite significant, I'm not sure I'd want to go over that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.