Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wedge volume control sliders #7902

Merged
merged 3 commits into from Jan 7, 2020
Merged

Wedge volume control sliders #7902

merged 3 commits into from Jan 7, 2020

Conversation

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Jan 5, 2020

Current:
image

This patch:
image

The MIN ' ' ' ' ' MAX scale has seemed really awkward to me for a long time so here's an attempt at removing it.

As a bonus, also a general-purpose polygon fill function.

@nielsmh nielsmh force-pushed the nielsmh:volcontrols branch from 2a1b852 to bb947b8 Jan 5, 2020
src/gfx.cpp Outdated Show resolved Hide resolved
src/gfx.cpp Outdated Show resolved Hide resolved
src/gfx.cpp Outdated Show resolved Hide resolved
@nielsmh nielsmh force-pushed the nielsmh:volcontrols branch from bb947b8 to e73365f Jan 5, 2020
Copy link
Member

@LordAro LordAro left a comment

Seems more or less fine. I like all the consts :)

src/gfx.cpp Outdated Show resolved Hide resolved
src/gfx.cpp Outdated Show resolved Hide resolved
src/gfx.cpp Outdated Show resolved Hide resolved
src/gfx.cpp Outdated Show resolved Hide resolved
src/gfx.cpp Outdated Show resolved Hide resolved
src/gfx.cpp Outdated Show resolved Hide resolved
@nielsmh nielsmh force-pushed the nielsmh:volcontrols branch from e73365f to 3720120 Jan 6, 2020
@nielsmh nielsmh requested a review from LordAro Jan 6, 2020
src/gfx.cpp Show resolved Hide resolved
src/gfx.cpp Show resolved Hide resolved
src/gfx.cpp Outdated Show resolved Hide resolved
@nielsmh nielsmh force-pushed the nielsmh:volcontrols branch from 3720120 to 23fcf53 Jan 7, 2020
@LordAro
LordAro approved these changes Jan 7, 2020
@nielsmh nielsmh merged commit 7413d65 into OpenTTD:master Jan 7, 2020
8 checks passed
8 checks passed
OpenTTD CI Build #20200107.12 succeeded
Details
OpenTTD CI (Linux commit-checker) Linux commit-checker succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.9) Linux linux-amd64-clang-3.9 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.