Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move commit checker from Azure Pipelines to Github Actions #7943

Merged
merged 2 commits into from Jan 19, 2020

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Jan 16, 2020

Basic workflow but logs should be less hidden and easier to read.
It can probably be improved with annotations and other stuff.

Copy link
Member

@TrueBrain TrueBrain left a comment

Minor things, more style; lgtm otherwise

.github/workflows/commit-checker.yml Outdated Show resolved Hide resolved
.github/workflows/commit-checker.yml Outdated Show resolved Hide resolved
.github/workflows/commit-checker.yml Outdated Show resolved Hide resolved
.github/workflows/commit-checker.yml Show resolved Hide resolved
@glx22
Copy link
Contributor Author

@glx22 glx22 commented Jan 16, 2020

Running version here

@glx22 glx22 force-pushed the commit-check branch 5 times, most recently from 1451a5f to 0788c5f Compare Jan 17, 2020
Copy link
Contributor Author

@glx22 glx22 left a comment

I found a way to get all the PR commits. First step is to get the latest commit of target branch. Then we can get commits only in the merge. Finally the commit check is done for the relevant commits.

.github/workflows/commit-checker.yml Outdated Show resolved Hide resolved
.github/workflows/commit-checker.yml Outdated Show resolved Hide resolved
.github/workflows/commit-checker.yml Outdated Show resolved Hide resolved
.github/workflows/commit-checker.yml Outdated Show resolved Hide resolved
.github/workflows/commit-checker.yml Outdated Show resolved Hide resolved
.github/workflows/commit-checker.yml Outdated Show resolved Hide resolved
Copy link
Member

@TrueBrain TrueBrain left a comment

LGTM! Let's fix things when we find cases where it breaks :D

@LordAro LordAro merged commit 9d5dd89 into OpenTTD:master Jan 19, 2020
7 checks passed
@glx22 glx22 deleted the commit-check branch Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants