Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7944: Demolishing locks built on rivers didn't always restore the river #7946



Copy link

@SamuXarick SamuXarick commented Jan 17, 2020

No description provided.

Copy link

@LordAro LordAro commented Jan 21, 2020

Having tested it, it's not immediately clear why IsWaterTile does not work for the sloped water, but does work for the flat water. Should HasTileWaterGround be used for the ends of the lock as well?

Copy link
Contributor Author

@SamuXarick SamuXarick commented Jan 21, 2020

It works for the flat water because...

The lower and upper tiles of the lock are getting WaterClass after the clear command in the case of object on river (rocky land). In Test mode, the WaterClass becomes WATER_CLASS_CANAL by failing IsWaterTile check, because the clear command was also in test mode. But in Exec mode, the tile resulting by the clear command is a river tile, without the rocks, WaterClass then is WATER_CLASS_RIVER.

MakeLock(tile, _current_company, dir, wc_lower, wc_upper, wc_middle); is only called in DC_EXEC mode, garanteeing the correct wc_upper/wc_lower.

Then when removing the lock, MakeWaterKeepingClass will ensure rivers are restored, by looking at the WaterClass of those 2 tiles.

In short, DC_TEST and DC_EXEC are being toyed around with the WaterClass for the upper/lower tiles. The middle tile is not. WaterClass is being checked before the clear command. For a river with rocks on it, IsTileWater test false, thus WaterClass for middle tile is WATER_CLASS_CANAL, but for HasTileWaterGround it returns WATER_CLASS_RIVER.

LordAro previously approved these changes Feb 9, 2020
Copy link

@LordAro LordAro commented Feb 9, 2020

@SamuXarick This needs a rebase due to commit-checker changes, can you do?

@LordAro LordAro added the backport requested label Feb 9, 2020
@SamuXarick SamuXarick force-pushed the lock-restore-river-on-rocky-land-river branch from db019e4 to 20dc446 Compare Feb 9, 2020
LordAro approved these changes Feb 9, 2020
@nielsmh nielsmh merged commit 30fe001 into OpenTTD:master Feb 9, 2020
8 checks passed
@SamuXarick SamuXarick deleted the lock-restore-river-on-rocky-land-river branch Feb 23, 2020
@LordAro LordAro added backported and removed backport requested labels Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants