Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative: move commit checker from Azure Pipelines to Github Actions #7948

Closed
wants to merge 2 commits into from

Conversation

@TrueBrain
Copy link
Member

TrueBrain commented Jan 18, 2020

Meant as alternative to #7943
Example result: https://github.com/TrueBrain/OpenTTD/pull/10/checks

Main drawback of this approach is that when a commits are pushed while the Action is starting, that Action can pick up a newer version that it is supposed to. I would estimate that as rare, and if it happens there also isn't a real issue. But it is a bit sad we have to use the reference, and we cannot use the hash or something :)

@TrueBrain TrueBrain changed the title Move commit checker from Azure Pipelines to Github Actions Alternative: move commit checker from Azure Pipelines to Github Actions Jan 18, 2020
@TrueBrain
Copy link
Member Author

TrueBrain commented Jan 18, 2020

Closing in favour of #7943 .

@TrueBrain TrueBrain closed this Jan 18, 2020
@TrueBrain TrueBrain deleted the TrueBrain:glx_commit_check branch Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.