Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7868: Missing override attribute. #7963

Merged
merged 1 commit into from Jan 26, 2020
Merged

Fix #7868: Missing override attribute. #7963

merged 1 commit into from Jan 26, 2020

Conversation

@PeterN
Copy link
Member

PeterN commented Jan 26, 2020

Fixes compilation warning.

@LordAro
Copy link
Member

LordAro commented Jan 26, 2020

Didn't we get rid of the /* virtual */ comments when override was added? Should probably remove them

@PeterN PeterN force-pushed the PeterN:fix-7868 branch from b464f9b to 071d081 Jan 26, 2020
@PeterN PeterN merged commit fff05cf into OpenTTD:master Jan 26, 2020
8 checks passed
8 checks passed
Commit checker
Details
OpenTTD CI Build #20200126.8 succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.9) Linux linux-amd64-clang-3.9 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@PeterN PeterN deleted the PeterN:fix-7868 branch Jan 26, 2020
@nielsmh
Copy link
Contributor

nielsmh commented Jan 26, 2020

There's several more classes missing override attributes around. They just don't generate warnings because they don't use the attribute anywhere else in the class or its superclasses. I think clang has a way to be more annoying about it?

douiwby added a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.