Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 805ecd32be64e14d8555ebc06eadf673bdf401ee: Incorrect length specifier #7995

Closed
wants to merge 1 commit into from

Conversation

@Berbe
Copy link
Contributor

Berbe commented Feb 10, 2020

g++ (Debian 8.3.0-6) 8.3.0 complains:

warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t' {aka 'long unsigned int'} [-Wformat=]
   IConsolePrintF(CC_ERROR, "ERROR: Maximum kick message length is 254 characters. You entered %d characters.", kick_message_length);

In 805ecd3, variable type got changed, but not the printf length specifier.

@LordAro
Copy link
Member

LordAro commented Feb 10, 2020

This was already fixed in trunk by #7994 . It will be backported to the release branch before the next release

@LordAro LordAro closed this Feb 10, 2020
@LordAro
Copy link
Member

LordAro commented Feb 10, 2020

Also, please avoid using the full 40char commit hash in commit messages - don't rely on GH to shorten it for you!

@Berbe Berbe deleted the Berbe:length-specifier branch Feb 10, 2020
@Berbe
Copy link
Contributor Author

Berbe commented Feb 10, 2020

I thought relying on short hashes was a bad idea?

@LordAro
Copy link
Member

LordAro commented Feb 10, 2020

Depends. With 3-4 characters you're going to run into problems. 7-10 you'll have no problems at all ever. Even the Linux kernel only needs 8 to uniquely identify every single one of its commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.