Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBSD: fix endianness detection #7996

Merged
merged 1 commit into from Feb 11, 2020
Merged

Conversation

@julianaito
Copy link
Contributor

julianaito commented Feb 11, 2020

Hi!

@rapenne-s reported to me that OpenTTD colors are off on OpenBSD/macppc (32-bit powerpc). I've found out it's because we don't implement endianness reporting like the rest; __*_ENDIAN and __BYTE_ORDER don't exist out of the box.

This PR adds the appropriate code to fix the issue.

(cc @bentley)

@LordAro
Copy link
Member

LordAro commented Feb 11, 2020

I feel like I should be surprised that there's any OBSD powerpc users at all, but equally I feel I should not be surprised... ;)

If you can fixup the commit message (we're quite strict about this!), I'll merge it in

@julianaito julianaito force-pushed the julianaito:obsd-endian branch from c2b67db to 031aa9c Feb 11, 2020
@julianaito
Copy link
Contributor Author

julianaito commented Feb 11, 2020

I feel like I should be surprised that there's any OBSD powerpc users at all, but equally I feel I should not be surprised... ;)

As many OSes EOL'd 32-bit powerpc support, people are slowly coming to us :)

If you can fixup the commit message (we're quite strict about this!), I'll merge it in

It's done!

Copy link
Contributor

planetmaker left a comment

yes, fair enough. Thanks for the PR

@LordAro LordAro merged commit 2196cd3 into OpenTTD:master Feb 11, 2020
8 checks passed
8 checks passed
Commit checker
Details
OpenTTD CI Build #20200211.2 succeeded
Details
OpenTTD CI (Linux linux-amd64-clang-3.9) Linux linux-amd64-clang-3.9 succeeded
Details
OpenTTD CI (Linux linux-amd64-gcc-6) Linux linux-amd64-gcc-6 succeeded
Details
OpenTTD CI (Linux linux-i386-gcc-6) Linux linux-i386-gcc-6 succeeded
Details
OpenTTD CI (MacOS) MacOS succeeded
Details
OpenTTD CI (Windows Win32) Windows Win32 succeeded
Details
OpenTTD CI (Windows Win64) Windows Win64 succeeded
Details
@glx22
Copy link
Contributor

glx22 commented Feb 11, 2020

Would be nice if you could check if endian detection works correctly for #7270. I think it should be ok as we rely on cmake, but who knows :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.