Codechange: Increase scrollbar length limit to UINT_MAX and make their length properly unsigned #8006
+151
−136
Conversation
There are 3 occurrences of |
f37d429
to
e3022c0
good catch, seems I'd missed quite a few |
462d4f2
to
77b52dc
77b52dc
to
50e6c94
50e6c94
to
9767467
9767467
to
f8d0365
f8d0365
to
800b469
No longer crashes the game, tried a few windows, scrolling seems to work fine. I am just there will be some window that doesn't work as we want or what-ever, but we will fix that when people report it :D |
Shouldn't be merged yet, lots of size_t -> uint warnings on Windows. Going to have to readd a load of casts :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Also makes scrollbar internals properly use unsigned numbers. Bumped scrollbar limit to uint(32) as well, because why not
Fixes #7613