Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Double-click to rename vehicle #8008

Open
wants to merge 2 commits into
base: master
from

Conversation

@kiwitreekor
Copy link
Contributor

kiwitreekor commented Feb 18, 2020

Renaming vehicle is a bit complicated in current state, so renaming a number of vehicles takes long time. This patch allows double-click title bar of vehicle view window to rename vehicles.
openttd_doubleclick

@ldpl
Copy link
Contributor

ldpl commented Feb 18, 2020

It's not complicated already, same two clicks, just with some mouse movement in between. Perfectly ok for not so widely used function IMO. Totally not worth adding another obscure interface quirk that 99% of players won't even know about. Also, double click will probably bring even more suffer and despair to touchscreen ports UI.

@kiwitreekor
Copy link
Contributor Author

kiwitreekor commented Feb 18, 2020

As far as I know, pretty many people use this function, and I think clicking on its name to rename vehicle is intuitive enough.

@kiwitreekor kiwitreekor force-pushed the kiwitreekor:double_click branch from add824c to d7edbac Feb 20, 2020
Copy link
Member

LordAro left a comment

I don't have any issue with this in principle...

src/vehicle_gui.cpp Outdated Show resolved Hide resolved
src/vehicle_gui.cpp Outdated Show resolved Hide resolved
@telk5093
Copy link
Contributor

telk5093 commented Feb 22, 2020

It would be great if we can add a configuration for this if you don't disagree with increasing the number of settings.

@kiwitreekor kiwitreekor force-pushed the kiwitreekor:double_click branch 3 times, most recently from 7b403f2 to cda6f57 Feb 22, 2020
@kiwitreekor
Copy link
Contributor Author

kiwitreekor commented Feb 22, 2020

@telk5093 Now I added option to enable/disable it.

@LordAro
Copy link
Member

LordAro commented Feb 22, 2020

I don't agree with having a setting here. This isn't something that visibly changes the behaviour/look of the game. If you don't want to double-click... don't

@kiwitreekor kiwitreekor force-pushed the kiwitreekor:double_click branch from cda6f57 to 41803e1 Feb 22, 2020
@kiwitreekor
Copy link
Contributor Author

kiwitreekor commented Feb 22, 2020

@LordAro hmm... now reverted to original version.

@kiwitreekor kiwitreekor requested a review from LordAro Feb 22, 2020
@SamuXarick
Copy link
Contributor

SamuXarick commented Feb 27, 2020

I could double click on a competitor road vehicle and try rename it, only to get an error saying it's not mine.

The tooltip doesn't mention anything about double-click to rename, only to drag.

@James103
Copy link
Contributor

James103 commented Apr 15, 2020

Somehow the OpenTTD CI broke on this pull request and several others. One of the checks is saying "Expected" for months, the OpenTTD CI logs aren't found, but the Commit checker logs are still accessible. Maybe try running the checks again?

@kiwitreekor kiwitreekor force-pushed the kiwitreekor:double_click branch from 41803e1 to dfc1f96 Apr 25, 2020
@kiwitreekor
Copy link
Contributor Author

kiwitreekor commented Apr 25, 2020

I could double click on a competitor road vehicle and try rename it, only to get an error saying it's not mine.

The tooltip doesn't mention anything about double-click to rename, only to drag.

Fixed

@kiwitreekor kiwitreekor force-pushed the kiwitreekor:double_click branch from dfc1f96 to 70e4718 Apr 25, 2020
@techgeeknz
Copy link
Contributor

techgeeknz commented May 28, 2020

Currently, renaming things can be a pain. Would we be better served by placing a small “edit” icon next to re-nameable items? In instances where this name appears as the title of a window, the title bar seems like a perfectly logical place for such an icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.