Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Double-click to rename vehicle #8008

Closed
wants to merge 2 commits into from

Conversation

@kiwitreekor
Copy link
Contributor

@kiwitreekor kiwitreekor commented Feb 18, 2020

Renaming vehicle is a bit complicated in current state, so renaming a number of vehicles takes long time. This patch allows double-click title bar of vehicle view window to rename vehicles.
openttd_doubleclick

@ldpl
Copy link
Contributor

@ldpl ldpl commented Feb 18, 2020

It's not complicated already, same two clicks, just with some mouse movement in between. Perfectly ok for not so widely used function IMO. Totally not worth adding another obscure interface quirk that 99% of players won't even know about. Also, double click will probably bring even more suffer and despair to touchscreen ports UI.

@kiwitreekor
Copy link
Contributor Author

@kiwitreekor kiwitreekor commented Feb 18, 2020

As far as I know, pretty many people use this function, and I think clicking on its name to rename vehicle is intuitive enough.

Copy link
Member

@LordAro LordAro left a comment

I don't have any issue with this in principle...

src/vehicle_gui.cpp Outdated Show resolved Hide resolved
src/vehicle_gui.cpp Outdated Show resolved Hide resolved
@telk5093
Copy link
Contributor

@telk5093 telk5093 commented Feb 22, 2020

It would be great if we can add a configuration for this if you don't disagree with increasing the number of settings.

@kiwitreekor kiwitreekor force-pushed the double_click branch 3 times, most recently from 7b403f2 to cda6f57 Feb 22, 2020
@kiwitreekor
Copy link
Contributor Author

@kiwitreekor kiwitreekor commented Feb 22, 2020

@telk5093 Now I added option to enable/disable it.

@LordAro
Copy link
Member

@LordAro LordAro commented Feb 22, 2020

I don't agree with having a setting here. This isn't something that visibly changes the behaviour/look of the game. If you don't want to double-click... don't

@kiwitreekor
Copy link
Contributor Author

@kiwitreekor kiwitreekor commented Feb 22, 2020

@LordAro hmm... now reverted to original version.

@kiwitreekor kiwitreekor requested a review from LordAro Feb 22, 2020
@SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Feb 27, 2020

I could double click on a competitor road vehicle and try rename it, only to get an error saying it's not mine.

The tooltip doesn't mention anything about double-click to rename, only to drag.

@James103
Copy link
Contributor

@James103 James103 commented Apr 15, 2020

Somehow the OpenTTD CI broke on this pull request and several others. One of the checks is saying "Expected" for months, the OpenTTD CI logs aren't found, but the Commit checker logs are still accessible. Maybe try running the checks again?

@kiwitreekor
Copy link
Contributor Author

@kiwitreekor kiwitreekor commented Apr 25, 2020

I could double click on a competitor road vehicle and try rename it, only to get an error saying it's not mine.

The tooltip doesn't mention anything about double-click to rename, only to drag.

Fixed

@techgeeknz
Copy link
Contributor

@techgeeknz techgeeknz commented May 28, 2020

Currently, renaming things can be a pain. Would we be better served by placing a small “edit” icon next to re-nameable items? In instances where this name appears as the title of a window, the title bar seems like a perfectly logical place for such an icon.

@frosch123
Copy link
Member

@frosch123 frosch123 commented Dec 13, 2020

To add my opinion to the pile:

  • I would expect double-click to maximize/minimize/share the window.
  • For renaming i would expect some small button in the titlebar, that behaves the same for vehicles, stations, companies, and everything you can rename.
  • There was a similar dicussion about adding "scroll to" buttons to all windows that represent some entitiy with a location on the map.

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Dec 14, 2020

Many people have different expectations of their UI, depending on what they are used to in their day-to-day. OpenTTD's UI dates to, what, 1994, and wasn't aware of the many common concepts we have today. In result, it is a mixed bag of everything that was and was becoming. In short: the UI sucks :P

That said, I can fully understand that functionalities like this help some people, but that it frustrates the hell out of others. This needs a more generic fix, for example with presets or what-ever, to allow patches like this.

To not poke the bear too much, sadly, I think we should close this PR for now. I do not expect that we come to a consensus about it any time soon, and allowing any form of presets (or themes, or how-ever you want to call it) will take a while.

I am really sorry, as I personally like it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants