-
-
Notifications
You must be signed in to change notification settings - Fork 977
Fix #8020: Add missing docking tiles around industry neutral stations #8021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #8020: Add missing docking tiles around industry neutral stations #8021
Conversation
c95ba12
to
930ffc6
Compare
I'm not seeing why a savegame bump is necessary here |
It's to fix "broken" saves since SLV_MULTITILE_DOCKS |
src/saveload/afterload.cpp
Outdated
@@ -3123,6 +3123,12 @@ bool AfterLoadGame() | |||
} | |||
} | |||
|
|||
if (IsSavegameVersionBefore(SLV_FIX_NEUTRAL_STATION_DOCKING_TILE)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (IsSavegameVersionBefore(SLV_FIX_NEUTRAL_STATION_DOCKING_TILE)) { | |
if (IsSavegameVersionBefore(SLV_FIX_NEUTRAL_STATION_DOCKING_TILE) && !IsSavegameVersionBefore(SLV_MULTITILE_DOCKS)) { |
to not iterate all stations twice, as now the original IsSavegameVersionBefore(SLV_MULTITILE_DOCKS)
block above this fix will be correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other option is to extract the iteration from IsSavegameVersionBefore(SLV_MULTITILE_DOCKS)
block and run it unconditionally like AfterLoadRoadStops()
, removing the need for the savegame bump
930ffc6
to
329c40c
Compare
329c40c
to
ae95ed3
Compare
I'm prepared to say that the few missing tiles don't matter for savegames created between SLV_MULTIDOCK_TILES and now. There's not been a (stable) release between then anyway |
Agree with @LordAro here, a bump is not strictly necessary. The missing tiles mean some water industries won't have ships docking in all positions but it's not a game-breaking catastrophe. |
No description provided.