Fix #7644: (Cocoa) Manually set colorspace to sRGB

[spauka]

This commit manually sets the colorspace for the window to sRGB, as suggested in #7644 by @SoothedTau, to fix performance issues on OSX when using devices that use the P3 colorspace by default. This makes the game run smoothly on my laptop, with the full 33fps rate.

[nielsmh]

Crashes for me on macOS 10.13.6 (Macbook Pro, late 2010 model). I haven't looked into the details of the crash yet.
Tested master and this PR rebased onto master, builds of master do work normally.

Assertion failed: (this->cgcontext != NULL), function WindowResized, file /Users/nielsm/dev/OpenTTD/src/video/cocoa/wnd_quartz.mm, line 588.
 
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	0x00007fff52bdab66 __pthread_kill + 10
1   libsystem_pthread.dylib       	0x00007fff52da5080 pthread_kill + 333
2   libsystem_c.dylib             	0x00007fff52b361ae abort + 127
3   org.openttd.openttd           	0x000000010cb53e5c HandleCrash(int) + 316 (crashlog_osx.cpp:249)
4   libsystem_platform.dylib      	0x00007fff52d98f5a _sigtramp + 26
5   ???                           	0x000000011cad3088 initialPool + 40
6   libsystem_c.dylib             	0x00007fff52b361ae abort + 127
7   libsystem_c.dylib             	0x00007fff52afe1ac __assert_rtn + 320
8   org.openttd.openttd           	0x000000010cd276e9 WindowQuartzSubdriver::WindowResized() + 345
9   org.openttd.openttd           	0x000000010cd268e5 WindowQuartzSubdriver::SetVideoMode(int, int, int) + 1109 (wnd_quartz.mm:349)
10  org.openttd.openttd           	0x000000010cd277eb QZ_CreateWindowQuartzSubdriver(int, int, int) + 251 (wnd_quartz.mm:486)
11  org.openttd.openttd           	0x000000010cd21e03 VideoDriver_Cocoa::Start(char const* const*) + 659 (cocoa_v.mm:405)
12  org.openttd.openttd           	0x000000010c9d53cc DriverFactoryBase::SelectDriverImpl(char const*, Driver::Type) + 924 (driver.cpp:120)
13  org.openttd.openttd           	0x000000010c9d4fe1 DriverFactoryBase::SelectDriver(char const*, Driver::Type) + 17 (driver.cpp:87)
14  org.openttd.openttd           	0x000000010cb4245b openttd_main(int, char**) + 4075 (openttd.cpp:770)
15  org.openttd.openttd           	0x000000010cb574d7 main + 151 (unix.cpp:261)
16  libdyld.dylib                 	0x00007fff52a8a015 start + 1

[nielsmh]

I tested from a clean starting point. Just adding the [ this->window setColorSpace:[ NSColorSpace sRGBColorSpace ] ]; after window creation in WindowQuartzSubdriver::SetVideoMode() seems to improve the performance a lot. All the other moving the color_space around and trying to make it a member variable seems unnecessary.

[spauka]

@nielsmh Thanks for checking, I was running without assertions which hid this error!

Latest commit fixes the crash you experienced, WindowResized was being called before the colorspace was set. Although if you feel it's cleaner I/you can also remove the color_space member variable...

[spauka]

Thanks for the review, I've implemented both requested changes.

done, will wait on @nielsm for ok

[orudge]

Seems to work better for me on 10.14.6 (MacBook Pro 15-inch 2019)

[LordAro]

good enough

[andythenorth]

Performance is measurably better with this PR versus 1.10.0 beta 2 (using in-game FPS).

This PR re-introduces the unfortunate magenta cast per #7644 (comment)

Without wanting to be dramatic about it, that makes the game very visually unappealing, the magenta sprites are unpleasant and the contrast is significantly reduced.

I guess there might just be no remedy for that.