Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: [AzurePipelines] Update MacOS image to 10.14 #8028

Merged
merged 1 commit into from Mar 13, 2020

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Feb 29, 2020

As per https://devblogs.microsoft.com/devops/removing-older-images-in-azure-pipelines-hosted-pools/, macOS-10.13 image will be removed from azure in the next month. So update to 10.14 to see what happens.

Could also update to 10.15 instead? Not sure if we want to do that for compatibility reasons or anything.

Will need to be backported to 1.10 branch so that the release can happen :)

@LordAro LordAro added the backport requested label Feb 29, 2020
@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Feb 29, 2020

Can we get a bundle of the build from this made available for download? I'd like to test whether it will still run on 10.13.

@LordAro
Copy link
Member Author

@LordAro LordAro commented Feb 29, 2020

There is the variable MACOSX_DEPLOYMENT_TARGET: 10.9 already specified. Assuming that's doing what I think it is, I'd expect no issues with compatibility

@LordAro
Copy link
Member Author

@LordAro LordAro commented Feb 29, 2020

Interestingly, the linker warnings appear to have gone away: This branch vs master
Gestalt compile warnings are unchanged

nielsmh
nielsmh approved these changes Mar 7, 2020
Copy link
Contributor

@nielsmh nielsmh left a comment

It's probably good. I assume the compile would break if you asked for compatibility with a version the SDK no longer supports.

@glx22 glx22 merged commit d44a2e4 into OpenTTD:master Mar 13, 2020
8 checks passed
@glx22
Copy link
Contributor

@glx22 glx22 commented Mar 13, 2020

10 days to test it live should be enough.

@LordAro LordAro deleted the update-osx-image branch Mar 13, 2020
@LordAro LordAro added backported and removed backport requested labels Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants