Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Buttons to select script profile in the AI/GS configuration window #8047

Conversation

@SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Mar 26, 2020

Adds 3 buttons with each profile on the AI/GS config window, and refreshes AI Parameters when changing to another profile.

screenshot#1
screenshot#2
screenshot#3

@SamuXarick SamuXarick force-pushed the settings-profile-in-ai-config-window branch from e6755c9 to ce3de35 Mar 26, 2020
@LordAro
Copy link
Member

@LordAro LordAro commented Apr 5, 2020

Code seems fine, but I guess the question is whether or not we want to expose a "difficulty level" again. I know it still exists for AIs, but there's nothing else, and it would almost feel a bit out of place...

@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Apr 8, 2020

We don't want to expose difficulty levels.

Generally we are better served by having less UI, not more.

@SamuXarick
Copy link
Contributor Author

@SamuXarick SamuXarick commented Apr 8, 2020

Should the difficulty preset default to hard then? It's currently on easy. Scripts are still required to configure values for easy, medium, hard, and even custom which is no longer selectable. Is there a way to make only one of them required (possibly hard) and the others optional? If so, then how would compatibility work for older API versions?

@glx22
Copy link
Contributor

@glx22 glx22 commented Apr 8, 2020

I think the best place for this is AI parameters window. And not using buttons but looking like a standard setting with arrows.

@SamuXarick
Copy link
Contributor Author

@SamuXarick SamuXarick commented Apr 12, 2020

@glx22 But the setting is global, it's not per AI.

@Yexo
Copy link
Contributor

@Yexo Yexo commented Jun 1, 2020

We don't want to expose difficulty levels.

I tend to agree. Then again, we should be consistent here: if we opt for not exposing the difficulty levels in the UI, we should remove the setting for it completely.

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Dec 14, 2020

A remnant of the past. Old AIs used it, so NoAI got it .. but it is just a horrible concept, that nobody really uses or implemented correctly. We should instead remove the final remains of this, and be gone with this silly "feature" :)

@TrueBrain TrueBrain closed this Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants