Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8060, 5880f14: Restore admin network API compatibility. #8061

Merged
merged 1 commit into from Apr 5, 2020

Conversation

@frosch123
Copy link
Member

@frosch123 frosch123 commented Apr 5, 2020

No description provided.

nielsmh
nielsmh approved these changes Apr 5, 2020
Copy link
Contributor

@nielsmh nielsmh left a comment

Looks like the correct solution to me.

/** Destination of our chat messages. */
/**
* Destination of our chat messages.
* @warning The values of the enum items are part of the admin network API. Only append at the end.
Copy link
Member

@LordAro LordAro Apr 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically, "Only append at the end" is redundant. "Only append, do not insert into the enum" might be better

@LordAro LordAro merged commit 7fe2916 into OpenTTD:master Apr 5, 2020
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants