Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: [Script] Improve copying a list into another empty list. #8097

merged 1 commit into from Apr 26, 2020


Copy link

@michicc michicc commented Apr 25, 2020

No description provided.

Copy link

@LordAro LordAro commented Apr 26, 2020

It's not clear how this makes any difference at all - if the list is empty, surely the iteration doesn't do anything?

Copy link

@SamuXarick SamuXarick commented Apr 26, 2020

Sem Título

Copy link

@glx22 glx22 commented Apr 26, 2020

The iterations happens on the added list, not on the destination.

Copy link

@LordAro LordAro left a comment

Ah, that makes sense

@michicc michicc merged commit 1f1345d into OpenTTD:master Apr 26, 2020
8 checks passed
@michicc michicc deleted the pr/script_list_add_empty branch Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants