Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8093: Build+Refit changed game-state in command test run, and thus caused desyncs #8103

Merged
merged 3 commits into from May 3, 2020

Conversation

@frosch123
Copy link
Member

@frosch123 frosch123 commented May 1, 2020

Still did not test this properly :)

@frosch123 frosch123 force-pushed the fixrefittestrun branch from 396a3c1 to d8d17c5 May 1, 2020
@frosch123 frosch123 changed the title Fix #8093: Do not call OrderBackup::Restore in the command test run, and use DC_AUTOREPLACE for actions that shall be reverted. Fix #8093: Build+Refit changed game-state in command test run, and thus caused desyncs May 1, 2020
Copy link
Contributor

@glx22 glx22 left a comment

All my tests passed.

@LordAro
Copy link
Member

@LordAro LordAro commented May 3, 2020

Needs a rebase now the ogfx change has been split out

frosch123 added 3 commits May 3, 2020
… and thus caused desyncs.

Use DC_AUTOREPLACE for actions that shall be reversibe, in this case:
- Do not rearrange free wagons in test-run.
- Do not discard OrderBackups.
The latter was not triggered by actual auto-replace, since it does not set a 'user'.
@frosch123 frosch123 force-pushed the fixrefittestrun branch from fd66b97 to 7727910 May 3, 2020
LordAro
LordAro approved these changes May 3, 2020
@frosch123 frosch123 merged commit 9f2e23d into OpenTTD:master May 3, 2020
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants